Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage for RPC clients #515

Closed
albrow opened this issue Nov 8, 2019 · 0 comments
Closed

Improve test coverage for RPC clients #515

albrow opened this issue Nov 8, 2019 · 0 comments
Assignees
@jalextowle
Labels
tech debt A code quality issue is not urgent but could cause problems down the line if not addressed testing Issues related to improving our tests

Comments

@albrow
Copy link
Contributor

albrow commented Nov 8, 2019

See #496 and #514. We've recently had to fix bugs in both the Go and the TypeScript RPC clients. We should improve test coverage for both clients to avoid these kinds of issues moving forward. We should write integration tests that:

  1. Spin up a Mesh node to serve as the RPC server.
  2. Hit all possible endpoints using both the Go and TypeScript RPC clients.
@albrow albrow added tech debt A code quality issue is not urgent but could cause problems down the line if not addressed testing Issues related to improving our tests labels Nov 8, 2019
@jalextowle jalextowle self-assigned this Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jalextowle jalextowle

Labels
tech debt A code quality issue is not urgent but could cause problems down the line if not addressed testing Issues related to improving our tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@albrow @mintcloud @jalextowle