core: Use consistent asynchronous API #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrow
commented
Jul 23, 2019
| @@ -39,7 +41,9 @@ func main() { | |||
| if err != nil { | |||
| log.WithField("error", err.Error()).Fatal("could not initialize app") | |||
| } | |||
| if err := app.Start(); err != nil { | |||
| ctx, cancel := context.WithCancel(context.Background()) | |||
| defer cancel() | |||
There was a problem hiding this comment.
It's a little awkward that we have both defer cancel() and defer app.Close() but that will go away once all the packages that core uses are also using the same consistent asynchronous API.
fabioberger
approved these changes
Jul 24, 2019
albrow
force-pushed
the
feature/core-consistent-async-api
branch
from
eaf06b9
to
b6078a7
Compare
Co-Authored-By: Fabio B <me@fabioberger.com>
albrow
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #96.
Since I was already changing some related code, I went ahead and fixed #299 in this PR too.