Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: Use consistent asynchronous API #300

merged 2 commits into from Jul 24, 2019


Copy link

albrow commented Jul 23, 2019

Related to #96.

Since I was already changing some related code, I went ahead and fixed #299 in this PR too.

@albrow albrow requested a review from fabioberger Jul 23, 2019
@@ -39,7 +41,9 @@ func main() {
if err != nil {
log.WithField("error", err.Error()).Fatal("could not initialize app")
if err := app.Start(); err != nil {
ctx, cancel := context.WithCancel(context.Background())
defer cancel()

This comment has been minimized.

Copy link

albrow Jul 23, 2019

Author Member

It's a little awkward that we have both defer cancel() and defer app.Close() but that will go away once all the packages that core uses are also using the same consistent asynchronous API.

core/core.go Outdated Show resolved Hide resolved
@albrow albrow force-pushed the feature/core-consistent-async-api branch from eaf06b9 to b6078a7 Jul 24, 2019
Co-Authored-By: Fabio B <>
@albrow albrow merged commit c6529c7 into development Jul 24, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
@albrow albrow deleted the feature/core-consistent-async-api branch Jul 24, 2019
@albrow albrow changed the title Use consistent asynchronous API for core package core: Use consistent asynchronous API Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.