Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate addrs into bind and advertise addrs for bootstrap nodes #363

Merged
merged 1 commit into from Aug 15, 2019

Conversation

@albrow
Copy link
Member

albrow commented Aug 15, 2019

#360 was the right idea, but I ran into a problem when trying to run the new code on a Docker container with a non-local IP address. We need to separate the env vars into bind addresses and advertise addresses. You can only bind to localhost or an IP address in the Docker subnet, but for other peers who want to connect to us, we need to advertise the public IP address(es).

@albrow albrow requested a review from fabioberger Aug 15, 2019
@albrow albrow merged commit 1bfd288 into development Aug 15, 2019
1 check passed
1 check passed
ci/circleci: build Your tests passed on CircleCI!
Details
@albrow albrow deleted the fix/bootstrap-separate-bind-addrs branch Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.