Address comments

0xProject · Feb 14, 2020 · bd22263 · bd22263
1 parent 8371bc8
commit bd22263
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/contracts/broker/src/gods_unchained_utils.ts b/contracts/broker/src/gods_unchained_utils.ts
@@ -3,8 +3,8 @@ import { ERC1155AssetData } from '@0x/types';
 import { AbiEncoder, BigNumber } from '@0x/utils';
 
 export interface GodsUnchainedProperties {
-    proto: BigNumber;
-    quality: BigNumber;
+    proto: BigNumber | number;
+    quality: BigNumber | number;
 }
 
 const propertyDataEncoder = AbiEncoder.create([{ name: 'proto', type: 'uint16' }, { name: 'quality', type: 'uint8' }]);

diff --git a/contracts/integrations/test/broker/broker_test.ts b/contracts/integrations/test/broker/broker_test.ts
@@ -714,8 +714,8 @@ blockchainTests.resets('Broker <> Gods Unchained integration tests', env => {
     });
 
     describe('Data encoding/decoding tools', () => {
-        const MAX_UINT8 = new BigNumber(2).exponentiatedBy(8).minus(1);
-        const MAX_UINT16 = new BigNumber(2).exponentiatedBy(16).minus(1);
+        const MAX_UINT8 = 2 ** 8 - 1;
+        const MAX_UINT16 = 2 ** 16 - 1;
 
         it('correctly decodes property data', async () => {
             const properties = {

diff --git a/contracts/integrations/test/stop-limit/chainlink_stop_limit_test.ts b/contracts/integrations/test/stop-limit/chainlink_stop_limit_test.ts
@@ -27,7 +27,7 @@ import { LocalBalanceStore } from '../framework/balances/local_balance_store';
 import { DeploymentManager } from '../framework/deployment_manager';
 import { ChainlinkStopLimitContract, TestChainlinkAggregatorContract } from '../wrappers';
 
-blockchainTests.resets.only('Chainlink stop-limit order tests', env => {
+blockchainTests.resets('Chainlink stop-limit order tests', env => {
     let deployment: DeploymentManager;
     let balanceStore: BlockchainBalanceStore;
     let initialBalances: LocalBalanceStore;