This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Use staticcall for external function calls in MixinSignatureValidator #1012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abandeali1
force-pushed
the
feature/contracts/staticcall
branch
2 times, most recently
from
f4c5a77
to
6c72d4f
Compare
recmo
suggested changes
Aug 24, 2018
| 32 // output size is 32 bytes | ||
| ) | ||
| // Signature is valid if call did not revert and returned true | ||
| isValid := and(success, mload(cdStart)) |
There was a problem hiding this comment.
This only works if the called contract returns a non-zero odd number for true, like 1. I'm not sure if the ABI guarantees that boolean true is always encoded as 1 (instead of anything non-zero like in C).
To fix we could do and(success, iszero(iszero(mload(cdStart)))).
| 32 // output size is 32 bytes | ||
| ) | ||
| // Signature is valid if call did not revert and returned true | ||
| isValid := and(success, mload(cdStart)) |
| view | ||
| returns (bool isValid) | ||
| { | ||
| bytes memory calldata = abi.encodeWithSelector( |
There was a problem hiding this comment.
I think this will bumb the memory pointer unnecessarily, leading to extra gas cost. (not an issue)
| view | ||
| returns (bool isValid) | ||
| { | ||
| bytes memory calldata = abi.encodeWithSelector( |
abandeali1
force-pushed
the
feature/contracts/staticcall
branch
from
6c72d4f
to
f1283eb
Compare
abandeali1
force-pushed
the
feature/contracts/staticcall
branch
from
f1283eb
to
070eff6
Compare
recmo
approved these changes
Aug 24, 2018
maurelian
reviewed
Sep 3, 2018
| walletAddress, // address of Wallet contract | ||
| cdStart, // pointer to start of input | ||
| mload(calldata), // length of input | ||
| cdStart, // write input over output |
maurelian
reviewed
Sep 3, 2018
| validatorAddress, // address of Validator contract | ||
| cdStart, // pointer to start of input | ||
| mload(calldata), // length of input | ||
| cdStart, // write input over output |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.[sol-cov] Fixed bug.