This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
[instant] Viewport specific errors #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/wip-viewport-conditional-animations
5 tasks
BMillman19
approved these changes
Nov 8, 2018
fabioberger
added a commit
that referenced
this pull request
Nov 8, 2018
* development: (51 commits) [instant] Viewport specific errors (#1228) Added more comments Include wholeNumberSchema in sra-spec schemas chore(instant): fix linter Fix isNode fix(instant): update buy quote at start up in the case of default amount chore(instant): increase max bundle size for bundle watch Small code review tweaks fix: apply css reset to overlay as well fix(website): turn off production flag when building locally feat(instant): add Account to the ProviderState feat(instant): fallback to an empty wallet provider when none is injected [order_utils.py] is_signature_valid, via Exchange contract (#1216) chore: linter fix: progress bar fix: use fontSize prop in button feat: make instant resistant to external styles chore(instant): update OrderState enum to follow capitalization conventions feat: add faux externall css file Take out unneeded conditionals ...
BMillman19
added a commit
that referenced
this pull request
Nov 9, 2018
* development: [instant] Viewport specific errors (#1228) Added more comments Include wholeNumberSchema in sra-spec schemas chore(instant): fix linter Fix isNode fix(instant): update buy quote at start up in the case of default amount fix: apply css reset to overlay as well fix(website): turn off production flag when building locally chore: linter fix: progress bar fix: use fontSize prop in button feat: make instant resistant to external styles feat: add faux externall css file Add upstream issue Use const require instead of import Fix tslint issues Use detect-node Set curstom inspect printer in BigNumber
This was referenced Jun 20, 2023
This was referenced Nov 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way in which we display errors based on if you are on a small screen (mobile) or if you are on a larger screen (assuming desktop):
A few notes about things which could be improved, but are turning out to be a hassle, and perhaps could wait for a cleanup task, esp. since this branch has taken a while to get in it's current state:
positionon the animationTransitionInfo. It feels as though this should be sent in as a separate prop, as it always is the same between the starting and ending transition. Although, this leaves flexibility to transition to different positions.width: 100%;I have another branch which I need to merge into this (or create a separate PR) which handles the dismissible overlay on mobile.
squashupon mergingDesktop:
Mobile:
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.[sol-cov] Fixed bug.