Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

[instant][review only] Heartbeat for updating account info #1233

Closed
wants to merge 2 commits into from
Closed

[instant][review only] Heartbeat for updating account info #1233

wants to merge 2 commits into from

Conversation

steveklebanoff
Copy link
Contributor

Description

⚠️ For review only, change base branch to development once #1232 is merged ⚠️

Sets a heartbeat for updating account info

Testing instructions

Types of changes

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: [sol-cov] Fixed bug.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

steveklebanoff
steveklebanoff commented Nov 8, 2018
View reviewed changes
packages/instant/src/constants.ts
@@ -10,6 +10,7 @@ export const WEB_3_WRAPPER_TRANSACTION_FAILED_ERROR_MSG_PREFIX = 'Transaction fa
export const GWEI_IN_WEI = new BigNumber(1000000000);
export const ONE_SECOND_MS = 1000;
export const ONE_MINUTE_MS = ONE_SECOND_MS * 60;
export const ACCOUNT_UPDATE_INTERVAL_TIME_MS = ONE_SECOND_MS * 15;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what the right value is here, we can tweak once we have a UI connected

@coveralls
Copy link

coveralls commented Nov 8, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.009%) to 84.712% when pulling 624f5ce on feature/instant/account-heartbeat into c84e163 on feature/instant/account-state-change.

@steveklebanoff
Copy link
Contributor Author

Closing in favor of #1237

@adamlaska adamlaska mentioned this pull request Nov 5, 2022
Open
@adamlaska adamlaska mentioned this pull request Dec 25, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BMillman19 BMillman19 Awaiting requested review from BMillman19

@fragosti fragosti Awaiting requested review from fragosti

Assignees
No one assigned
Labels
@0x/instant
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@steveklebanoff @coveralls