Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

[website] Fix code splitting #1238

Merged
merged 1 commit into from
Nov 12, 2018
Merged

[website] Fix code splitting #1238

merged 1 commit into from
Nov 12, 2018

Conversation

BMillman19
Copy link
Contributor

Description

Testing instructions

http://staging-0xproject.s3-website-us-east-1.amazonaws.com/

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: [sol-cov] Fixed bug.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

fragosti
fragosti approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@fragosti fragosti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

packages/website/tsconfig.json
}
},
"module": "esnext",
"moduleResolution": "node"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really this is it? Huh

@BMillman19 BMillman19 changed the title [website] Fix code splitting [WIP][website] Fix code splitting Nov 9, 2018
@BMillman19 BMillman19 added the WIP label Nov 9, 2018
@BMillman19 BMillman19 changed the title [WIP][website] Fix code splitting [website] Fix code splitting Nov 12, 2018
@BMillman19 BMillman19 removed the WIP label Nov 12, 2018
@coveralls
Copy link

Coverage Status

Coverage increased (+0.009%) to 84.721% when pulling 3b421ef on fix/website/code-splitting into df8fd36 on development.

@BMillman19 BMillman19 merged commit 9e4a594 into development Nov 12, 2018
@BMillman19 BMillman19 deleted the fix/website/code-splitting branch November 12, 2018 05:21
@adamlaska adamlaska mentioned this pull request Nov 5, 2022
Open
@adamlaska adamlaska mentioned this pull request Dec 25, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fragosti fragosti fragosti approved these changes

@fabioberger fabioberger Awaiting requested review from fabioberger

@steveklebanoff steveklebanoff Awaiting requested review from steveklebanoff

Assignees
No one assigned
Labels
@0x/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BMillman19 @coveralls @fragosti