Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

[instant] Handle privacy mode in wallets #1239

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

BMillman19
Copy link
Contributor

Description

  • Make sure we are calling enable() on providers in situations where possible
  • Remove the unused error AccountState

Testing instructions

Visit dogfood on coinbase wallet, current metamask, and old versions of metamask
http://0x-instant-dogfood.s3-website-us-east-1.amazonaws.com/

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Prefix PR title with [WIP] if necessary.
  • Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: [sol-cov] Fixed bug.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • Add new entries to the relevant CHANGELOG.jsons.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.009%) to 84.712% when pulling 38896c9 on feature/instant/privacy-mode into 26cbe7a on development.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants