This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Move @0x/connect schemas to @0x/json-schemas #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LogvinovLeon
changed the title
fabioberger
approved these changes
Nov 12, 2018
packages/json-schemas/CHANGELOG.json
Outdated
| "changes": [ | ||
| { | ||
| "note": | ||
| "Improve schemas by enforcing that amounts that must be whole numbers (e.g Order asset amounts) no longer allow decimal amounts", | ||
| "pr": 1173 | ||
| }, | ||
| { | ||
| "note": "Add schemas from @0x/connect" |
LogvinovLeon
requested review from
BMillman19 and
steveklebanoff
as code owners
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.[sol-cov] Fixed bug.