This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Add Coordinator contracts support in dev tools #1689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* development: (93 commits) Linting Copied MixinAssetProxyDispatcher from exchange Added deployed contract packages to readme (and link to top-level readme) Bumped version of ERC1155Proxy to 0.5.5 + merged ERC20Proxy/ERC721Proxy/MultiAssetProxy dependencies into base contract files Make credits program participants 1 row Correct comment in `hashEIP712Message()` in `LibEIP712Domai.sol`. Merge janky changelog notes in `types` package. Correct changelog note in `coordinator` changelog. Add PR numbers to changelogs. additional zero outcome tests renamed perUnitValue to valueMultiplier added test for amount=0 Adjusted changelog version since nothing has been published during this PR Added calldatacopy comment Do not revert if value or amount are zero. Only if amount is non-zero and there is an overflow. updated comment for calldatacopy yarn.lock for erc1155 proxy added exports for 1155 proxy Renamed tokenIds -> ids, tokenValues -> values, callbackData -> data to be consistent with the ERC1155 reference implementation. Rebased against development Ran prettier Updated changelogs and documentation for erc1155 proxy ...
* development: Fix order-watcher version
…e in Coordinator tests
fabioberger
requested review from
abandeali1,
hysz and
LogvinovLeon
as code owners
fabioberger
changed the title
abandeali1
approved these changes
Mar 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
CoordinatorandCoordinatorRegistrycontract artifacts tocontract-artifacts, wrappers toabi-gen-wrappersand deploys both contracts in the migration script.TODO
contract-addressespackageTesting instructions
Types of changes
Checklist:
[WIP]if necessary.