This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
Fix/3.0/c18 #2265
Merged
Fix/3.0/c18 #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jalextowle
force-pushed
the
fix/3.0/c18
branch
from
d163d34
to
c848f71
Compare
jalextowle
force-pushed
the
fix/3.0/c18
branch
from
c848f71
to
7283a16
Compare
abandeali1
approved these changes
Oct 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There were several unused functions in LibBytes that were pointed out by Consensys Diligence including:
deepCopyBytes,popLast20Bytes,readBytesWithLength,writeAddress,writeBytes32,writeUint256, andwriteBytesWithLength.I only removed
deepCopyBytes,popLast20Bytes,readBytesWithLength, andwriteBytesWithLengthfor now. The tests were also updated to look more like the tests that have been written recently.Testing instructions
PKG=@0x/contracts-utils yarn testTypes of changes
Checklist:
[WIP]if necessary.