This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
RFQ-T: validate assetData & add more tests #2552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steveklebanoff
commented
Apr 14, 2020
•
steveklebanoff
commented
- Validates taker and maker asset data
- Validates signedOrderSchema instead of just orderSchema
- Adds some more logs
- Adds some more tests
steveklebanoff
requested review from
BMillman19,
dave4506 and
fragosti
as code owners
4 tasks
steveklebanoff
commented
Apr 14, 2020
| this._schemaValidator.isValid(order, schemas.orderSchema), | ||
| ); | ||
| const validatedOrdersWithStringInts = ordersWithStringInts.filter(order => { | ||
| const hasValidSchema = this._schemaValidator.isValid(order, schemas.signedOrderSchema); |
There was a problem hiding this comment.
Note that this changed from orderSchema to signedOrderSchema
feuGeneA
approved these changes
Apr 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.