This repository has been archived by the owner on Jul 9, 2021. It is now read-only.
feat: Add CREAM as a liquidity source #2715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkroeger
changed the title
alexkroeger
changed the title
3 tasks
dekz
approved these changes
Oct 14, 2020
contracts/zero-ex/contracts/src/transformers/bridges/BridgeAdapter.sol
Outdated
Show resolved
Hide resolved
packages/asset-swapper/src/utils/market_operation_utils/sampler_operations.ts
Outdated
Show resolved
Hide resolved
dorothy-zbornak
approved these changes
Oct 15, 2020
| const MAX_POOLS_FETCHED = 3; | ||
| // tslint:enable:custom-no-magic-numbers | ||
|
|
||
| export class CreamPoolsCache { |
There was a problem hiding this comment.
Is there really any meaningful difference between this class and BalancerPoolsCache? Does it make sense to just modify and inherit from that class, passing in getPoolsWithTokens() and parsePoolData() callbacks to the super?
packages/asset-swapper/src/utils/market_operation_utils/index.ts
Outdated
Show resolved
Hide resolved
packages/asset-swapper/src/utils/market_operation_utils/index.ts
Outdated
Show resolved
Hide resolved
packages/asset-swapper/src/utils/market_operation_utils/types.ts
Outdated
Show resolved
Hide resolved
packages/asset-swapper/src/utils/market_operation_utils/orders.ts
Outdated
Show resolved
Hide resolved
alexkroeger
changed the title
dekz
approved these changes
Oct 16, 2020
There was a problem hiding this comment.
Think this might need a rebase ontop of latest development, then a re-publish once on development for 0xAPI. So that the sha matches the commit.
Once this is merged github basically deletes the sha making it hard to find which AS release was which commit, unless published off development.
So rebase, merge, publish:private
packages/asset-swapper/src/utils/market_operation_utils/index.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add CREAM to asset-swapper.
CREAM (Crypto Rules Everything Around Me) is a Balancer clone.
Testing instructions
Types of changes
Checklist:
[WIP]if necessary.