Skip to content
This repository has been archived by the owner on Jul 9, 2021. It is now read-only.

New tslint rules #883

Merged
merged 4 commits into from
Jul 18, 2018
Merged

New tslint rules #883

merged 4 commits into from
Jul 18, 2018

Conversation

LogvinovLeon
Copy link
Contributor

@LogvinovLeon LogvinovLeon commented Jul 17, 2018

Description

  • Upgrade tslint to the newest version
  • Add new rules:
  • Fixes linter failures after adding new rules

Most notable changes:

  • prefer-readonly rule requires readonly attr for readonly properties.
  • no-invalid-this
    • This rule helped us find a bug when we were overriding a this context of an already bound react prop in the dialog

Testing instructions

yarn lint

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • Change requires a change to the documentation.
  • Added tests to cover my changes.
  • Added new entries to the relevant CHANGELOG.jsons.
  • Labeled this PR with the 'WIP' label if it is a work in progress.
  • Labeled this PR with the labels corresponding to the changed package.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 83.811% when pulling bf8ac3b on feature/tslint-improvements into a9038f2 on v2-prototype.

@LogvinovLeon LogvinovLeon merged commit f3241ff into v2-prototype Jul 18, 2018
@LogvinovLeon LogvinovLeon deleted the feature/tslint-improvements branch August 21, 2018 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants