Skip to content

Commit

Permalink
add note explaining that matchOrders is not implemented
Browse files Browse the repository at this point in the history
  • Loading branch information
xianny committed Apr 26, 2019
1 parent 5c48af6 commit 5c3864a
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions v2/coordinator-specification.md
Expand Up @@ -166,6 +166,8 @@ When interacting with coordinator orders, the following Exchange methods must be
| [`batchCancelOrders`](https://github.com/0xProject/0x-protocol-specification/blob/master/v2/v2-specification.md#batchcancelorders) | No |
| [`cancelOrdersUpTo`](https://github.com/0xProject/0x-protocol-specification/blob/master/v2/v2-specification.md#cancelordersupto) | No |

Note: `matchOrders` is not currently implemented in [0x-coordinator-server](https://github.com/0xProject/0x-coordinator-server). The server will not generate approval signatures for a `matchOrders` request. However, the Coordinator contract still requires approval signatures for any `matchOrders` transactions. As such, `matchOrders` transactions must be executed directly through the Exchange contract.

`executeTransaction` will revert under the following conditions:

- The `tx.origin` (Ethereum transaction signer) differs from the passed in `txOrigin` parameter.
Expand Down

0 comments on commit 5c3864a

Please sign in to comment.