Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Teton Finance] v4 support #384

Merged
merged 6 commits into from Feb 5, 2022
Merged

[Teton Finance] v4 support #384

merged 6 commits into from Feb 5, 2022

Conversation

alexkroeger
Copy link
Contributor

@alexkroeger alexkroeger commented Jan 6, 2022

This PR updates 0x-starter-project to v4.

Scenarios included:

  • Fill a 0x API swap/quote response
  • Fill ERC20 limit order
  • Cancel pair limit orders
  • Fill ERC20 RFQ order
  • Fill ERC20 RFQ order with a maker order signer
  • Subscribe to RFQ order fill events
  • Execute Metatransaction
  • Fill ERC20 OTC order
  • Fill taker-signed ERC20 OTC order
  • Fill a quote via TransformERC20

This work was funded by a 0x Community DAO grant to Teton Finance.

@alexkroeger alexkroeger changed the title [Teton Finance] Update to for v4 support [Teton Finance] v4 support Jan 6, 2022
@SHA-2048
Copy link

SHA-2048 commented Jan 9, 2022

Great work @alexkroeger , I've read all the scenario and code is very clear and readable.

I was wondering about use in a webApp use case, would there be anything specific to pay attention to? (I remember something about the provider where you need to define a special one for wrapping metamask)

Also most Dapp developers will be using the 0x API, so it can be very helpful to have a scenario for that as well

@alexkroeger
Copy link
Contributor Author

Great work @alexkroeger , I've read all the scenario and code is very clear and readable.

I was wondering about use in a webApp use case, would there be anything specific to pay attention to? (I remember something about the provider where you need to define a special one for wrapping metamask)

Also most Dapp developers will be using the 0x API, so it can be very helpful to have a scenario for that as well

Hey @SHA-2048, thanks for reading thru!

Re: webapp use cases there is additional documentation on 0x-subproviders that I can link the readme.

Having 0x API scenarios would be useful--I'll look into that this week.

@jlin27 jlin27 closed this Feb 4, 2022
@jlin27 jlin27 reopened this Feb 4, 2022
- Forwarder buy orders (ERC721)
- Standard Relayer API fill order example
- Dutch Auction (decreasing price auction)
- [Fill ERC20 limit order](./src/scenarios/fill_erc20_limit_order.ts)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the "Fill a 0x API swap/quote response" to this list?

@jlin27 jlin27 merged commit ee8b1c5 into 0xProject:master Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants