Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build without warnings #17

Merged
merged 3 commits into from Jun 20, 2019
Merged

Build without warnings #17

merged 3 commits into from Jun 20, 2019

Conversation

z2trillion
Copy link
Contributor

build finishes without warnings. Previously, they were
warning: unused import: crate::u256h
warning: unused import: hex_literal::*
warning: cannot borrow proof as mutable because it is also borrowed as immutable
warning[E0502]: cannot borrow res as immutable because it is also borrowed as mutable

@z2trillion z2trillion requested review from recmo and aleph-v June 20, 2019 00:47
@recmo
Copy link
Contributor

recmo commented Jun 20, 2019

Try

RUSTFLAGS="-Dwarnings" cargo build --all --all-targets

recmo
recmo suggested changes Jun 20, 2019
View reviewed changes
src/field.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@z2trillion z2trillion requested a review from recmo June 20, 2019 21:21
@z2trillion z2trillion merged commit 84cc0de into master Jun 20, 2019
@recmo recmo deleted the mason/fix/build_warnings branch July 11, 2019 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@recmo recmo recmo approved these changes

@aleph-v aleph-v Awaiting requested review from aleph-v

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@z2trillion @recmo