Build without warnings

.cargo/config

@@ -0,0 +1,3 @@
+[alias]
+tr = "test --release"
+bs = "build --tests --features strict"

Cargo.toml

@@ -39,3 +39,7 @@ debug = true # Debug symbols are required for profiling. Remove for production!
 # TODO: Make sure it doesn't hurt wasm
 [build]
 rustflags = ["-C target-cpu=native"]
+
+[features]
+# Treat warnings as a build error.
+strict = []

src/fibonacci.rs

@@ -672,7 +672,8 @@ pub fn fib_proof(witness: FieldElement) -> Channel {
         }
         0
     };
-    proof.write(&pow_find_nonce(12).to_be_bytes());
+    let nonce = pow_find_nonce(12);
+    proof.write(&nonce.to_be_bytes());
 
     let num_queries = 20;
     let mut query_indices = Vec::with_capacity(num_queries + 3);

src/field.rs

@@ -110,21 +110,27 @@ impl FieldElement {
 }
 
 pub fn invert_batch(to_be_inverted: &[FieldElement]) -> Vec<FieldElement> {
-    let mut res = Vec::with_capacity(to_be_inverted.len());
-    for item in to_be_inverted.iter() {
-        res.push(item.clone())
-    }
+    let n = to_be_inverted.len();
+    let mut inverses = cumulative_product(to_be_inverted);
 
-    for x in 1..res.len() {
-        res[x] *= res[x - 1].clone();
-    }
-    let mut inv = res[res.len() - 1].inv().unwrap(); //TODO: Enforce check to prevent uninvertable elements
-    for x in (1..res.len()).rev() {
-        res[x] = &res[x - 1] * &inv;
-        inv *= to_be_inverted[x].clone();
+    // TODO: Enforce check to prevent uninvertable elements.
+    let mut inverse = inverses[n - 1].inv().unwrap();
+    for i in (1..n).rev() {
+        inverses[i] = &inverses[i - 1] * &inverse;
+        inverse *= &to_be_inverted[i];
     }
-    res[0] = inv;
-    res.to_vec()
+    inverses[0] = inverse;
+    inverses
+}
+
+fn cumulative_product(elements: &[FieldElement]) -> Vec<FieldElement> {
+    elements
+        .iter()
+        .scan(FieldElement::ONE, |running_product, x| {
+            *running_product *= x;
+            Some(running_product.clone())
+        })
+        .collect()
 }
 
 impl From<U256> for FieldElement {

src/lib.rs

@@ -1,5 +1,6 @@
-// TODO: #![deny(warnings, missing_docs)]
+// TODO: #![deny(missing_docs)]
 #![warn(clippy::all)]
+#![cfg_attr(feature = "strict", deny(warnings))]
 
 pub mod binops;
 pub mod channel;

src/polynomial.rs

@@ -1,6 +1,4 @@
 use crate::field::FieldElement;
-use crate::u256h;
-use hex_literal::*;
 
 pub fn eval_poly(x: FieldElement, coefficients: &[FieldElement]) -> FieldElement {
     let mut b = FieldElement::ZERO;
@@ -15,6 +13,7 @@ mod tests {
     use super::*;
     use crate::u256::*;
     use crate::u256h;
+    use hex_literal::*;
 
     #[test]
     fn poly_eval_test() {