Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Added rewards section to account page #292

Merged
merged 5 commits into from
May 6, 2020

Conversation

alexkroeger
Copy link
Contributor

@alexkroeger alexkroeger commented May 1, 2020

Changes:

  • Added Rewards section to account page
  • Added loading screen to account page
  • Added utility to calculate expected rewards by pool
  • Changed pool stats type to include additional fields for operator, member stake
  • Added an "EpochWithFees" type to accept an epoch object with total fees

Dependencies:

Testing:

  • Tested locally

Loading screen:
image

Rewards section:
image
image

Rewards section mobile view:
image

@mintcloud
Copy link
Contributor

Great stuff! A couple of things on copy

  • let's use "Accumulated Rewards" instead of "Available Rewards" to stress the fact that you don't have to withdraw them each time
  • I would add a tooltip to the "Estimated for this epoch" : “This estimate is expected to fluctuate at the beginning of an epoch, and progressively converge on the final value"

@burnsben
Copy link

burnsben commented May 1, 2020

Screen Shot 2020-05-01 at 4 47 05 PM

Apologies as my original designs were a bit jank. Would it be possible to separate these containers out with a space instead of the divider line? could go ~25% width on the first 2, and 50% on the withdraw section

and align the text left

Copy link
Contributor

@johnrjj johnrjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for updating the testing data;

Totally understand the decimal-js dep, I've been meaning to do that b/c of the equation. This page's payload won't have a noticeable difference in relative size b/c of the dep either, tbh.

@johnrjj
Copy link
Contributor

johnrjj commented May 5, 2020

Just ping if I should deploy this -- or if you want to, I can send the instructions over (if you haven't deployed before)

@alexkroeger alexkroeger merged commit 36ba4e3 into development May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants