Fix #84 Schools are not plotted in map in streamlit app #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Few additional features have been added in the codebase and improvise in the readability of streamlit codebase 1) Schools will now be plotted on the map alongside centers, using a different colored marker. 2) The list serial number now starts from 1 instead of 0. - In "filter_data" function, when filtering the DataFrame based on the selected type and value, the filter was being applied directly to the DataFrame without resetting the index. 3) Removed thousand separators from scode and cscode. 4) Changed the marker style for better aesthetics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Schools will now be plotted on the map alongside centers, using a different colored marker.
The list serial number now starts from 1 instead of 0.
Removed thousand separators from scode and cscode.
Changed the marker style for better aesthetics.
Pull request type
Please tick the type of change your PR introduces: