feat: l1 l2 messaging postman #234
Conversation
In this commit there is not re-work on the EthAddress type. However, this type may be changed to use a starknet_types crate type instead of starknet_api one.
For some endpoint of the starknet-server, we do want to accept u128 values for range verification. However, by default the u128 types only translates to json number. This commit introduces a U128HexOrDec deserializer that allows the retrieval of a u128 value from a string (hexadecimal or decimal string) without compromising the u128 range check
To be compliant with devnet-py, by default the accounts[0] of most known eth devnet like hardhat and anvil is used. As an extension from devnet-py, if a private_key is given, it is used instead. This allow the user to customize the account used for deployment of messaging contract without being blocked by a compiled version of devnet.
|
All solidity contracts are taken from https://github.com/starknet-io/starkgate-contracts/tree/main/src/starkware/starknet/solidity? Can we also document in readme.md how json artifact/artifacts are generated for future developers? Sooner or later this can change and we will need to make an update. |
There was a problem hiding this comment.
I'm approving the changes after having modified (IMO improved) the tests a bit. I also added foundry installation as a CI step and mention it as a testing pre-requisite in the root README.md. All of the commits I pushed can be found at the bottom of the PR page. Let me know if you think I did something I shouldn't have.
You're all good @FabijanC very nice changes, thank you for that. The testing is more comprehensive. |
Usage related changes
This PR will enable the usage of
postmanendpoints for messaging.Development related changes
New modules and configurations will be added with this PR. This will affect
how the devnet may be started.
Fixes #173
Fixes #236
Checklist:
./scripts/format.sh./scripts/clippy_check.shcargo test