Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove additional fields returned compared to RPC spec #335

Merged
merged 10 commits into from
Feb 7, 2024

Conversation

marioiordanov
Copy link
Contributor

@marioiordanov marioiordanov commented Feb 6, 2024

Usage related changes

Every method without exceptions follows the format of the RPC spec

Development related changes

Removed contract_class property from Declare transactions.
Removed serialization/deserialziation of contract_address property in DeployAccount transactions.
Refactored handle_transaction_result to accept new argument of type ContractClass.
Edited spec_instructions to not generate data for DeclareV0 txns, because they are not supported.
Removed TODO statement in json_rpc::spec_reader::mod::test_spec_methods test

NEW
Removed EXPECTED_RPC_VERSION and used instead RPC_SPEC_VERSION

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@marioiordanov marioiordanov linked an issue Feb 6, 2024 that may be closed by this pull request
@marioiordanov marioiordanov marked this pull request as ready for review February 6, 2024 12:13
@marioiordanov marioiordanov merged commit c121c26 into main Feb 7, 2024
1 check passed
@marioiordanov marioiordanov deleted the additional_fields branch February 7, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON-RPC methods returning extra properties not in the spec
2 participants