Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change account-class default_value to cairo1 #339

Merged
merged 10 commits into from
Feb 20, 2024
Merged

change account-class default_value to cairo1 #339

merged 10 commits into from
Feb 20, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Feb 7, 2024 •
edited

Usage related changes

  • change default account class to cairo1

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@mikiw mikiw linked an issue Feb 7, 2024 that may be closed by this pull request
Class hash calculation in devnet differs from starkli class-hash #331
Closed
@mikiw mikiw requested a review from FabijanC February 20, 2024 11:18
@mikiw mikiw merged commit b41e566 into main Feb 20, 2024
1 check passed
@mikiw mikiw deleted the account-contract-version-bugfix branch February 20, 2024 13:54
@FabijanC FabijanC mentioned this pull request Feb 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class hash calculation in devnet differs from starkli class-hash
2 participants
@mikiw @FabijanC