Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix empty object params bug #346

Merged
merged 2 commits into from
Feb 14, 2024
Merged

Conversation

jelilat
Copy link
Contributor

@jelilat jelilat commented Feb 12, 2024

Usage related changes

Closes #345

Development related changes

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

Copy link
Contributor

@marioiordanov marioiordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

circle ci will fail on ./scripts/format.sh

Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Looks much better with the test now.

@jelilat
Copy link
Contributor Author

jelilat commented Feb 14, 2024

@marioiordanov

circle ci will fail on ./scripts/format.sh

Fixed now

@FabijanC FabijanC merged commit 1015e64 into 0xSpaceShard:main Feb 14, 2024
@FabijanC FabijanC mentioned this pull request Feb 15, 2024
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON RPC Request with Empty Params {} Not Supported
3 participants