Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade zerocopy, unsafe-libyaml, h2; use rust 1.74; update cache key #354

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Upgrade zerocopy, unsafe-libyaml, h2; use rust 1.74; update cache key #354

merged 3 commits into from
Mar 1, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Feb 20, 2024 •
edited

Usage related changes

Development related changes

  • Use new cache key (Cargo.lock + rust-toolchain.toml)

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@FabijanC FabijanC marked this pull request as ready for review February 20, 2024 11:41
marioiordanov
marioiordanov reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@marioiordanov marioiordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should circleci config be changed to use 1.74.0

@FabijanC FabijanC changed the title Upgrade zerocopy, unsafe-libyaml, h2 Upgrade zerocopy, unsafe-libyaml, h2; use rust 1.74; update cache key Mar 1, 2024
@FabijanC FabijanC merged commit 6306ad6 into main Mar 1, 2024
1 check passed
@FabijanC FabijanC deleted the fix-dependabot-alerts branch March 1, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FabijanC @marioiordanov