Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort blocks #388

Merged
merged 38 commits into from
Mar 27, 2024
Merged

Abort blocks #388

merged 38 commits into from
Mar 27, 2024

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Mar 19, 2024 •
edited

Usage related changes

  • add of abort block endpoint

Development related changes

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@mikiw mikiw marked this pull request as draft March 19, 2024 10:06
@mikiw mikiw linked an issue Mar 26, 2024 that may be closed by this pull request
Abort blocks #313
Closed
@mikiw mikiw marked this pull request as ready for review March 26, 2024 14:56
FabijanC
FabijanC requested changes Mar 26, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
crates/starknet-devnet-core/src/starknet/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_abort_blocks.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_abort_blocks.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_abort_blocks.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_abort_blocks.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_abort_blocks.rs Outdated Show resolved Hide resolved
@mikiw mikiw merged commit bd9e76c into main Mar 27, 2024
1 check passed
@mikiw mikiw deleted the abort-blocks branch March 27, 2024 15:46
@FabijanC FabijanC mentioned this pull request Mar 28, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abort blocks
4 participants
@mikiw @FabijanC @marioiordanov @Hanae1963