Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use BigUint instead of U256 for balance; remove primitive-types #390

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Use BigUint instead of U256 for balance; remove primitive-types #390

merged 3 commits into from
Mar 20, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Mar 20, 2024 •
edited

Usage related changes

Development related changes

  • Replace U256 with BigUint
  • Remove the primitive-types dependency.

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section in README.md if this PR resolves it
  • Updated the tests
  • All tests are passing - cargo test

@FabijanC
Fix failing test
ab0de55 
* now all tests are passing, so [skip ci] - new CI run follows after merge
@FabijanC FabijanC merged commit 5c18b0d into main Mar 20, 2024
@FabijanC FabijanC deleted the fix-after-377 branch March 20, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikiw mikiw mikiw approved these changes

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@FabijanC @mikiw @marioiordanov