Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always predeclare Cairo0 and Cairo1 account classes #402

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Always predeclare Cairo0 and Cairo1 account classes #402

merged 5 commits into from
Mar 29, 2024

Conversation

FabijanC
Copy link
Contributor

Usage related changes

Development related changes

  • AccountClassChoice had to be moved from starknet-devnet to starknet-devnet-core
  • Reduce class cloning

Checklist:

  • Checked the relevant parts of the Development section of the docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Checked the TODO section of the docs
  • Updated the tests
  • All tests are passing - docs

@FabijanC FabijanC merged commit a147b4c into main Mar 29, 2024
1 check passed
@FabijanC FabijanC deleted the predeclare-both-accounts branch March 29, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Both Cairo0 and Cairo1 accounts should always be predeclared
2 participants
@FabijanC @marioiordanov