Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn on forking mismatch #409

Merged
merged 6 commits into from
Apr 3, 2024
Merged

Warn on forking mismatch #409

merged 6 commits into from
Apr 3, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 2, 2024

Usage related changes

  • Log a warning (but continue operating) if origin and spawned Devnet differ in one of the following:
    • chain ID
    • JSON-RPC API version
  • Fix bug of failed Devnet startup when forking from a URL using https
    • by installing the ca-certificates package in Dockerfile

Development related changes

  • Remove redundant comment in config.yml
  • Simplify PR template
  • Rename print_ utilities to log_ for consistency's sake
  • Update Dockerfile

Checklist:

  • Checked the relevant parts of the Development section of the docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Checked if the TODO section of the docs can be edited
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

[skip ci]

Co-authored-by: Ivan Pavičić <ivan.pavicic@live.com>
@FabijanC FabijanC merged commit 9b40420 into main Apr 3, 2024
@FabijanC FabijanC deleted the warn-fork-mismatch branch April 3, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants