Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make request body size limit configurable #410

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Apr 3, 2024

Usage related changes

Development related changes

  • Refactor: extract host, port, timeout and request_body_size_limit to ServerConfig
  • Remove redundant code from ServerConfig

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks legit

Copy link
Contributor

@marioiordanov marioiordanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the addition of this new cli param request_body_size_limit, I think its time to split the timeout option and this new one into separate config, which are related to configuration on the infrastructure part of the application. The other ones are options for the business logic

@FabijanC FabijanC merged commit 8131d0a into main Apr 4, 2024
1 check passed
@FabijanC FabijanC deleted the request-body-size-limit branch April 4, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request body size limit should be configurable
3 participants