Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Transaction enum #411

Merged
merged 14 commits into from
Apr 4, 2024
Merged

Refactor Transaction enum #411

merged 14 commits into from
Apr 4, 2024

Conversation

marioiordanov
Copy link
Contributor

Development related changes

  • Extract transaction_hash out of Transaction enum variants. The reason is starknet_getBlockWithReceipts RPC method, returns transaction and receipt. According to the spec the transaction_hash is present in the receipt property of the response.
  • StarknetResponse enum variants are refactored to reflect the return type, not the method that the variant corresponds to.

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@marioiordanov marioiordanov marked this pull request as ready for review April 4, 2024 08:16
@FabijanC FabijanC self-requested a review April 4, 2024 08:22
FabijanC
FabijanC requested changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crates/starknet-devnet-server/src/api/json_rpc/spec_reader/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-server/src/api/json_rpc/mod.rs Show resolved Hide resolved
crates/starknet-devnet-core/src/starknet/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-core/src/starknet/add_declare_transaction.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-types/src/rpc/transactions/declare_transaction_v0v1.rs Show resolved Hide resolved
crates/starknet-devnet-types/src/rpc/transactions/l1_handler_transaction.rs Show resolved Hide resolved
@marioiordanov marioiordanov linked an issue Apr 4, 2024 that may be closed by this pull request
Refactor Transaction enum #363
Closed
@marioiordanov marioiordanov merged commit 0a0d6ec into main Apr 4, 2024
1 check passed
@marioiordanov marioiordanov deleted the refactor_txn branch April 4, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Transaction enum
2 participants
@marioiordanov @FabijanC