Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty genesis block and remove init state #412

Merged
merged 17 commits into from
Apr 10, 2024
Merged

Conversation

mikiw
Copy link
Contributor

@mikiw mikiw commented Apr 4, 2024

Usage related changes

  • An empty genesis block was added.

Development related changes

  • An empty genesis block was added which caused some test changes.

Checklist:

  • Checked the relevant parts of development docs
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed, including the TODO section
  • Linked the issues which this PR resolves
  • Updated the tests if needed; all passing (execution info)

@mikiw mikiw marked this pull request as draft April 4, 2024 13:06
@mikiw mikiw linked an issue Apr 5, 2024 that may be closed by this pull request
@mikiw mikiw marked this pull request as ready for review April 5, 2024 14:49
@mikiw
Copy link
Contributor Author

mikiw commented Apr 5, 2024

I didn't self-review it but I think it's reviewable if someone has free time on Monday.

I still need to add documentation.

I consider the genesis block as block number zero, not the first block, just saying because some variables in tests has names likefirst_block.

@mikiw
Copy link
Contributor Author

mikiw commented Apr 6, 2024

I quickly self-review it so it can be reviewed from a code perspective. I'll add the documentation on Tuesday.

@mikiw mikiw requested a review from FabijanC April 6, 2024 08:02
crates/starknet-devnet-core/src/starknet/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet-core/src/starknet/mod.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_abort_blocks.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_abort_blocks.rs Outdated Show resolved Hide resolved
crates/starknet-devnet/tests/test_fork.rs Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mikiw mikiw requested a review from FabijanC April 9, 2024 14:36
@mikiw mikiw merged commit 6281795 into main Apr 10, 2024
1 check passed
@mikiw mikiw deleted the genesis-block-state branch April 10, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Genesis block
3 participants