Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Feature/predeployed accounts endpoint #138

Merged
merged 11 commits into from
Jun 24, 2022
Merged

Feature/predeployed accounts endpoint #138

merged 11 commits into from
Jun 24, 2022

Conversation

tabaktoni
Copy link
Contributor

@tabaktoni tabaktoni commented Jun 20, 2022 •
edited by FabijanC

Usage related changes

Created endpoint for retrieving devnet seeded accounts

/predeployed_accounts

Development related changes

  • Add jsonschema as a dev dependency.

Checklist:

  • Performed a self-review of the code
  • Rebased to the base branch
  • Documented the changes
  • Updated the tests
  • All tests are passing

FabijanC
FabijanC suggested changes Jun 20, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add tests for this new functionality?

All my other comments are more style-oriented.

README.md Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
starknet_devnet/blueprints/base.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@tabaktoni tabaktoni requested a review from FabijanC June 20, 2022 13:58
@FabijanC FabijanC mentioned this pull request Jun 22, 2022
Merged
6 tasks
FabijanC
FabijanC suggested changes Jun 23, 2022
View reviewed changes
test/support/assertions.py Show resolved Hide resolved
starknet_devnet/account.py Show resolved Hide resolved
test/test_account_predeployed.py Show resolved Hide resolved
@FabijanC FabijanC self-requested a review June 24, 2022 07:45
@FabijanC FabijanC merged commit e6394d8 into master Jun 24, 2022
@FabijanC FabijanC deleted the feature/predeployed-accounts-endpoint branch June 24, 2022 07:46
@antazoey antazoey mentioned this pull request Jul 25, 2022
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FabijanC FabijanC FabijanC approved these changes

@badurinantun badurinantun Awaiting requested review from badurinantun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tabaktoni @FabijanC