Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused binds object in DockerWrapper #353

Closed
FabijanC opened this issue May 3, 2023 · 1 comment
Closed

Unused binds object in DockerWrapper #353

FabijanC opened this issue May 3, 2023 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@FabijanC
Copy link
Collaborator

FabijanC commented May 3, 2023

binds not used:

public async interact(options: InteractWrapperOptions): Promise<ProcessResult> {
const binds: String2String = {};
if (options.abi) {
binds[options.abi] = options.abi;
}
if (options.accountDir) {
binds[options.accountDir] = options.accountDir;
}
const preparedOptions = this.prepareInteractOptions(options);
const executed = this.execute("starknet", preparedOptions);
return executed;
}
}

Seems like nobody is complaining about something related to this, so it's not the highest priority. So the real task would be to determine if the binds object is really needed. If not - remove it, if yes - use it properly.

@FabijanC FabijanC added the bug Something isn't working label May 3, 2023
@FabijanC
Copy link
Collaborator Author

Closed via #361

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants