Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support estimate fee on declare v2 #361

Merged
merged 5 commits into from May 10, 2023
Merged

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented May 9, 2023

Usage related changes

  • NA

Development related changes

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:Add test for estimate fee on declare v2 starknet-hardhat-example#110
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL Nathan-SL requested a review from FabijanC May 9, 2023 09:07
src/account.ts Outdated Show resolved Hide resolved
src/account.ts Show resolved Hide resolved
@Nathan-SL Nathan-SL requested a review from FabijanC May 10, 2023 08:19
@Nathan-SL Nathan-SL merged commit 980680b into master May 10, 2023
@Nathan-SL Nathan-SL deleted the estimate-declarev2-fee branch May 10, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants