Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check to getBlockUtil #183

Merged
merged 1 commit into from Aug 11, 2022
Merged

Add check to getBlockUtil #183

merged 1 commit into from Aug 11, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Aug 11, 2022 •
edited

Usage related changes

  • Add check to getBlockUtil (the case when an object of type any is passed is not properly handled - defaulting to "latest" is done, which might be unwanted behavior if user passes number 2 (instead of passing as a property if the identifier object).

Development related changes

  • Add formatting script: npm run format (runs prettier and applies changes)

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.sh)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC FabijanC merged commit a9d75db into master Aug 11, 2022
@FabijanC FabijanC deleted the check-get-block branch August 11, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@FabijanC