Voyager contract verification #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dribeiro-ShardLabs
commented
Dec 3, 2021
•
dribeiro-ShardLabs
commented
- Implemented "starknet-verify" task, which queries Voyager for contract verifications
- Implemented "wait" flag for the "starknet-deploy" task, which if present waits until the status in the deployment transaction for a contract is "Pending"
…ard-Labs/starknet-hardhat-plugin into voyager-contract-verification
FabijanC
requested changes
Dec 3, 2021
FabijanC
requested changes
Dec 6, 2021
There was a problem hiding this comment.
The new changes seem to cover my comments from the last review, except the required changes to package-lock.json: #25 (comment)
FabijanC
approved these changes
Dec 6, 2021
ghost
approved these changes
Dec 6, 2021
FabijanC
requested changes
Dec 6, 2021
src/index.ts
Outdated
| @@ -349,7 +349,7 @@ task("starknet-deploy", "Deploys Starknet contracts which have been compiled.") | |||
| const execResult = processExecuted(executed); | |||
|
|
|||
| if(execResult == 0) | |||
| tx_hashes.push(executed.stdout.toString().match(".*Transaction hash: (?<tx_hash>\\w*).*").groups["tx_hash"]); | |||
| txHashes.push(executed.stdout.toString().match(".*Transaction hash: (?<tx_hash>\\w*).*").groups["tx_hash"]); | |||
There was a problem hiding this comment.
I guess you didn't want this line to look the way it does. Perhaps you meant to indent it and enclose with curly braces. Also, would it be possible to utilize extractTxHash from types.ts?
FabijanC
approved these changes
Dec 6, 2021
added 2 commits
December 6, 2021 16:39
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.