Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add predefined network for Testnet 2 #258

Merged
merged 4 commits into from Nov 30, 2022
Merged

Add predefined network for Testnet 2 #258

merged 4 commits into from Nov 30, 2022

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Nov 28, 2022 •
edited

Usage related changes

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.sh)
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

FabijanC
FabijanC requested changes Nov 28, 2022
View reviewed changes
src/utils.ts Outdated Show resolved Hide resolved
src/constants.ts Outdated Show resolved Hide resolved
test/configuration-tests/with-networks/check.ts Outdated Show resolved Hide resolved
@Nathan-SL
Use testnet 2 for tests on alphaGoerli
2c7386c 
- rename varibales
- add alphaGoerli2 on network.schema
- remove unnecessary variable use
@Nathan-SL
Update expected error message on test
f98d815 
- format code
FabijanC
FabijanC reviewed Nov 30, 2022
View reviewed changes
test/network.schema Outdated Show resolved Hide resolved
@FabijanC FabijanC self-requested a review November 30, 2022 10:19
@FabijanC FabijanC merged commit ff9b4b6 into master Nov 30, 2022
@FabijanC FabijanC deleted the alpha-goerli2-network branch November 30, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Predefine alpha-goerli 2
2 participants
@Nathan-SL @FabijanC