Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra logging of ClientConnectorError #279

Merged
merged 7 commits into from Dec 21, 2022
Merged

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Dec 16, 2022

Usage related changes

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
src/types.ts Outdated Show resolved Hide resolved
- Add a while true loop to retry status cheking
- use while loop inplace of do-while
- rename errorResponse to error
@FabijanC FabijanC merged commit 2a9940b into master Dec 21, 2022
@FabijanC FabijanC deleted the remove-extra-log branch December 21, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary logging of ClientConnectorError
2 participants