Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#200 Debugging contracts #284

Merged
merged 5 commits into from Dec 28, 2022
Merged

#200 Debugging contracts #284

merged 5 commits into from Dec 28, 2022

Conversation

shramee
Copy link
Contributor

@shramee shramee commented Dec 22, 2022 •
edited

Usage related changes

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
    • If src/type-extensions.ts was changed, updated the line number referencing this file in the ## API section of README.md
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

Closes #200

@FabijanC FabijanC self-requested a review December 23, 2022 15:44
FabijanC
FabijanC requested changes Dec 23, 2022
View reviewed changes
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good example! I would just improve the integrated-devnet section a bit.

www/docs/intro.md Outdated Show resolved Hide resolved
FabijanC
FabijanC reviewed Dec 23, 2022
View reviewed changes
www/docs/intro.md Outdated Show resolved Hide resolved
@shramee
Update intro.md
dd2e5e6 
Integrated Devnet stdout
~~DevNet~~ > Devnet
@shramee shramee requested review from FabijanC and removed request for Nathan-SL December 25, 2022 04:38
@shramee
Copy link
Contributor Author

shramee commented Dec 25, 2022

Sorry guys @Nathan-SL and @FabijanC,
The reviewer switch was unintentional, just clicked the request review refresh icon after updating but it changed the reviewer. 😰

@Nathan-SL Nathan-SL requested review from Nathan-SL and removed request for FabijanC December 28, 2022 07:02
@Nathan-SL Nathan-SL merged commit bad6dec into 0xSpaceShard:master Dec 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC requested changes

@Nathan-SL Nathan-SL Nathan-SL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document debugging possibility
3 participants
@shramee @FabijanC @Nathan-SL