Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to starknet 0.11.0 #328

Merged
merged 62 commits into from Apr 17, 2023
Merged

Adapt to starknet 0.11.0 #328

merged 62 commits into from Apr 17, 2023

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented Mar 2, 2023

Breaking changes

  • contract_address on transaction object from starknet.getTransaction(txHash) changed to sender_address
  • devnet.createBlock() no longer returns Block but an object with class_hash
  • devnet.sendMessageToL2() expects new argument paidFeeOnL1 to be passed
  • Response from devnet.setTime() and devnet.increaseTime() are updated.

Usage related changes

  • Closes Adapt to Starknet 0.11 #325
  • Add new hardhat plugin command npx hardhat starknet-compile-cairo1 to compile cairo1 contracts
  • Cairo1 compilation with dockerized environment.
  • Make cairo1 contracts recognizable by the recompiler
  • Adds declareV2 function
  • Uses starknet-devnet v0.5.0a1
  • Uses cairo-lang v0.11.0.1

Development related changes

  • Silents docker-vmlang-rust-test
  • npx hardhat starknet-compile skips cairo1 contracts

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:Adapt to cairo-lang 0.11.0  starknet-hardhat-example#104
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL Nathan-SL changed the title Update to cairo-lang 0.11.0a0 [skip ci] Adapt to starknet 0.11.0 Mar 2, 2023
@Nathan-SL Nathan-SL requested a review from FabijanC March 15, 2023 14:03
src/constants.ts Outdated Show resolved Hide resolved
src/starknet_cli_wrapper.py Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@Nathan-SL Nathan-SL marked this pull request as ready for review April 5, 2023 15:03
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we supporting cairo1 compilation through custom compiler (without docker)? If so, shouldn't this be tested? And if we want to test this, we need to add compiler installation to our CI/CD workflow.

scripts/ensure-python.sh Outdated Show resolved Hide resolved
src/starknet-wrappers.ts Outdated Show resolved Hide resolved
src/starknet-wrappers.ts Outdated Show resolved Hide resolved
src/adapt.ts Show resolved Hide resolved
src/adapt.ts Show resolved Hide resolved
src/starknet-wrappers.ts Show resolved Hide resolved
src/task-actions.ts Outdated Show resolved Hide resolved
src/external-server/external-server.ts Outdated Show resolved Hide resolved
src/account.ts Outdated Show resolved Hide resolved
src/cairo1-compiler.ts Show resolved Hide resolved
@Nathan-SL Nathan-SL requested a review from FabijanC April 14, 2023 09:07
src/starknet-wrappers.ts Outdated Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
src/account.ts Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
@Nathan-SL Nathan-SL requested a review from FabijanC April 17, 2023 10:58
@FabijanC FabijanC merged commit e11bb15 into master Apr 17, 2023
@FabijanC FabijanC deleted the addapt-0.11.0 branch April 17, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to Starknet 0.11
2 participants