Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constructor detection via casm file #354

Merged
merged 6 commits into from May 4, 2023
Merged

Conversation

taco-paco
Copy link
Contributor

Usage related changes

  • No changes for user.

Development related changes

  • Removed file parsing on every new entry.
  • Common function for finding constructor
  • Verifying correctness of casm file

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor comments but looks like great improvement, thanks!

src/types/index.ts Outdated Show resolved Hide resolved
src/types/index.ts Show resolved Hide resolved
src/types/index.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@Nathan-SL Nathan-SL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FabijanC FabijanC changed the title Constructor detection via case file Constructor detection via casm file May 4, 2023
@FabijanC FabijanC merged commit 02c7681 into master May 4, 2023
6 checks passed
@FabijanC FabijanC deleted the constructor-detection branch May 4, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants