Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt.ts: add support for core::integer::u256 #358

Merged
merged 1 commit into from May 5, 2023

Conversation

cfal
Copy link
Contributor

@cfal cfal commented May 5, 2023

Usage related changes

Fixes handling for core::integer::u256, which should be represented as 2 felts.
Partly addresses #341

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC FabijanC self-requested a review May 5, 2023 07:56
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, nothing to add

@FabijanC FabijanC merged commit 4193389 into 0xSpaceShard:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants