Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix reading cairo 1.0 input specs #359

Merged
merged 2 commits into from May 5, 2023
Merged

fix reading cairo 1.0 input specs #359

merged 2 commits into from May 5, 2023

Conversation

cfal
Copy link
Contributor

@cfal cfal commented May 5, 2023

Usage related changes

cairo 1.0 events in the ABI have arguments listed under inputs instead of data: https://github.com/starkware-libs/cairo/blob/05867c82de42d5ee5cfa953dcca1cb826402f74b/crates/cairo-lang-starknet/src/abi_test.rs#L155

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@FabijanC FabijanC merged commit 424a687 into 0xSpaceShard:master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabijanC FabijanC FabijanC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cfal @FabijanC