Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: allow constructorless contracts #366

Merged
merged 1 commit into from May 12, 2023
Merged

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented May 12, 2023

Allow constructor-less contracts

Usage related changes

  • Fixes TypeError: Cannot read properties of undefined (reading 'selector') when getting contract factory with no constructor.

Development related changes

  • NA

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:
    • < EXAMPLE_REPO_PR_URL >
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

Allow constructor-less contracts
@Nathan-SL Nathan-SL requested a review from FabijanC May 12, 2023 07:47
@Nathan-SL Nathan-SL changed the title Fix bug: allow constructor-less contracts Fix bug: allow constructorless contracts May 12, 2023
Copy link
Collaborator

@FabijanC FabijanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but wrote this enhancement proposal: #367

@FabijanC FabijanC merged commit 6ad18dd into master May 12, 2023
@FabijanC FabijanC deleted the constructor-less-contract branch May 12, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants