Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition on proxy server #374

Merged
merged 12 commits into from Jun 7, 2023
Merged

Conversation

Nathan-SL
Copy link
Contributor

@Nathan-SL Nathan-SL commented May 31, 2023

Usage related changes

Development related changes

  • Adds a function to ensure proper assignment of a free port.

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Updated the test directory (with a test case consisting of network.json, hardhat.config.ts, check.ts)
  • Linked issues which this PR resolves
  • Created a PR to the plugin branch of starknet-hardhat-example:Add utility func to get n pre-deployed accounts starknet-hardhat-example#112
    • Modified test.sh to use my example repo branch
    • Restored test.sh to to use the original branch (after the example repo PR has been merged)
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

@Nathan-SL Nathan-SL requested a review from FabijanC May 31, 2023 04:07
@FabijanC FabijanC changed the title Fix bug on proxy server Fix race condition on proxy server Jun 7, 2023
@FabijanC FabijanC merged commit 1221c19 into master Jun 7, 2023
6 checks passed
@FabijanC FabijanC deleted the axios-retry-on-proxy-server branch June 7, 2023 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proxy server failure on multiple calls: starknet-venv-proxy exited with code=1 while running
2 participants