Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cairo1BinDir with dockerized plugin #408

Merged
merged 47 commits into from Sep 14, 2023
Merged

Allow cairo1BinDir with dockerized plugin #408

merged 47 commits into from Sep 14, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Sep 13, 2023 •
edited

Usage related changes

Development related changes

N/A

Checklist:

  • Formatted the code
  • No linter errors + tried to avoid introducing linter warnings
  • Performed a self-review of the code
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked issues which this PR resolves
  • All tests are passing (for external contributors who don't have access to the CI/CD pipeline)

Nathan-SL and others added 30 commits July 19, 2023 17:34
@Nathan-SL
WIP compiler downloader [skip ci]
23fb618
@Nathan-SL
Update cairo compiler downloader class
b7b8b5e 
- Allow download by specifying version
- Refactoring
@Nathan-SL
Add tests
d13ba88
@Nathan-SL
Add docs
18f978c
@Nathan-SL
Update stdout writer
5209bd9
@Nathan-SL
Remove zip file after extracting [skip ci]
b98a0df
@Nathan-SL
Update test
893a2b4
@Nathan-SL
Update docs [skip ci]
aa47556
@Nathan-SL
initiate ci
b78d9f0
@Nathan-SL
Avoid using slash
4c7b88b
@Nathan-SL
Make isDirEmpty non-method function
0db99f9
@Nathan-SL
Use path.join
e6e1744
@Nathan-SL
Format code
8d8e33c
@Nathan-SL
Avoid async Import
81bf0ee 
- import config.json on top of file
@Nathan-SL
Get os specific file name
2f2015c
@Nathan-SL
Install tar dependency
a59f5db
@Nathan-SL
Use tar for extracting
28813b2
@Nathan-SL
Validate config.starknet to only contain one of [cairo1BinDir, compil…
ff3d749 
…erVersion]
@Nathan-SL
Update compiler downloader
5efc50a 
- Update method name
- Update return type
- Ensure exact compilerVersion is installed
@Nathan-SL
Default compiler downloader to home dir
7c47175
@Nathan-SL
Fix bug with stdoud & stderr
e23dd4e
@Nathan-SL
Use stderr
b85a014
@FabijanC
Merge branch 'master' into compiler-downloader
6d5f553
@FabijanC
Add a couple of TODOs [skip ci]
6913d78
@FabijanC
Refactor; use tar-fs
a329ed4
@FabijanC
Fix cairo version in config.json
e1d4b06
@FabijanC
Add --single-file where missing in tests
62a7c52
@FabijanC
Use --add-pythonic-hints flag in cairo1 tests
e4d6f1b
@FabijanC
Fix compilation
192404c
@FabijanC
Refactor setup-compiler.sh
eae1031
@FabijanC FabijanC marked this pull request as ready for review September 13, 2023 13:45
Base automatically changed from compiler-downloader to master September 14, 2023 08:08
@FabijanC FabijanC merged commit ad1a41d into master Sep 14, 2023
@FabijanC FabijanC deleted the allow-cairo1bindir branch September 14, 2023 08:22
@FabijanC FabijanC mentioned this pull request Sep 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penovicp penovicp penovicp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cairo 1 compiler needs to be refactored
3 participants
@FabijanC @penovicp @Nathan-SL