Multiple sources paths, rejected transaction error message #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dribeiro-ShardLabs
changed the title
dribeiro-ShardLabs
changed the title
FabijanC
requested changes
Jan 31, 2022
src/task-actions.ts
Outdated
| resolve(); | ||
| }, | ||
| error => { | ||
| console.log(`Invoke transaction ${txHash} is REJECTED`); |
There was a problem hiding this comment.
Would it make sense to use console.error here?
There was a problem hiding this comment.
This remained, do we keep this as it is?
added 6 commits
February 1, 2022 12:26
dribeiro-ShardLabs
force-pushed
the
multiple-cairo-paths-config-file
branch
from
60b4307
to
2a66f1b
Compare
FabijanC
requested changes
Feb 1, 2022
FabijanC
reviewed
Feb 1, 2022
src/task-actions.ts
Outdated
| resolve(); | ||
| }, | ||
| error => { | ||
| console.log(`Invoke transaction ${txHash} is REJECTED`); |
There was a problem hiding this comment.
This remained, do we keep this as it is?
| cairoPaths.push(path); | ||
| }); | ||
| } | ||
| if (hre.config.paths.cairoPaths) { |
There was a problem hiding this comment.
This should be documented in Readme
FabijanC
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hardhat.configfile.