-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICON REQUEST] Added XAI and Zora network icons. #9
Conversation
…o ID issue, ran build.
Posting conversation here for reference; Constant paths are relative, so running Other scripts in Running bun run Updated script so ID is optional in the meantime (not sure how you define IDs & their impact) // populate-network-metadata.ts line 40
const lowerCaseId = network.id?.toLowerCase() || '' Script ran successfully. Then running Last commit may have been a mistake |
hey, thank you.
the "id" field should be mandatory, idk how coin-gecko could have a network without an also updated the script so it doesn't produce empty strings on I need to update the ReadMe and Contributing guides for the whole process 😅 |
I am also going to pause the github action, it has trouble checking out and committing, I'll reactive it once I fix it. sorry for the annoyance |
Hello again!
Had issues with conflicts on the previous PR, not sure why, also pretty new with working with forks and such...
Original PR - #8
Deleted bun.lockb, hard to resolve conflicts on binary file;
oven-sh/bun#5486 (comment)